Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes of typos, README and tests #77

Merged
merged 7 commits into from
Mar 13, 2024
Merged

Minor fixes of typos, README and tests #77

merged 7 commits into from
Mar 13, 2024

Conversation

JanJereczek
Copy link
Contributor

This PR:

  • fixes the typos we had in the title of paper.md.
  • provides an updated version of the README (with the correct installation information) and a description that is more coherent with the paper.
  • the tests written for the slope_change.jl pipeline have been included in runtests.jl (a reason why our code coverage was lower than expected).
  • (minor) additional tests for the change metrics.

@Datseris
Copy link
Member

tests fail currently

@JanJereczek
Copy link
Contributor Author

JanJereczek commented Mar 13, 2024

I noticed some errors in slope_change.jl and the associated significance, which were breaking the code. Also test/slope_change.jl had a couple bugs. They should be fixed now!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.39%. Comparing base (80db37a) to head (84f1a3c).

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #77       +/-   ##
===========================================
+ Coverage   75.76%   86.39%   +10.63%     
===========================================
  Files          16       16               
  Lines         392      397        +5     
===========================================
+ Hits          297      343       +46     
+ Misses         95       54       -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Datseris Datseris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, please increment patch version in Project.toml and tag a new release after merge!

@JanJereczek JanJereczek merged commit 3a19270 into main Mar 13, 2024
3 checks passed
@JanJereczek JanJereczek deleted the minors-paper branch March 13, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants