Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pvalues counting for surrogate significance is broken #65

Closed
Datseris opened this issue Dec 17, 2023 · 1 comment
Closed

pvalues counting for surrogate significance is broken #65

Datseris opened this issue Dec 17, 2023 · 1 comment
Assignees

Comments

@Datseris
Copy link
Member

Have a look here:

https://juliadynamics.github.io/TransitionsInTimeseries.jl/dev/examples/logistic/#Significance-via-random-Fourier-surrogates

this exacmple used to be perfectly fine. Now, every single time point gets a significance flag. I believe this is because of our re-worked p-value counting code. That code is also over-engineered. We should simplify it back to its original, most simple possible version, because the performance of this code does not matter at all: it has miniscule impact on overall runtime.

@JanJereczek
Copy link
Contributor

I have spotted the error. It came from how we newly handle nothing as an indicator. I will PR the fixed code soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants