Warnings about unused type variable

[mcabbott]

These are annoying:

WARNING: method definition for == at /Users/me/.julia/packages/ChainRulesCore/ctmSK/src/tangent_types/tangent.jl:68 declares type variable T but does not use it.
WARNING: method definition for getindex at /Users/me/.julia/packages/ChainRulesCore/ctmSK/src/tangent_types/tangent.jl:120 declares type variable T but does not use it.
WARNING: method definition for getindex at /Users/me/.julia/packages/ChainRulesCore/ctmSK/src/tangent_types/tangent.jl:120 declares type variable P but does not use it.
WARNING: method definition for canonicalize at /Users/me/.julia/packages/ChainRulesCore/ctmSK/src/tangent_types/tangent.jl:240 declares type variable L but does not use it.
WARNING: method definition for canonicalize at /Users/me/.julia/packages/ChainRulesCore/ctmSK/src/tangent_types/tangent.jl:241 declares type variable L but does not use it.

[devmotion]

I think that was fixed in #584? Maybe you use an old version of ChainRulesCore? For instance,

WARNING: method definition for == at /Users/me/.julia/packages/ChainRulesCore/ctmSK/src/tangent_types/tangent.jl:68 declares type variable T but does not use it.

refers to a type variable that was fixed in that PR and does not exist anymore on the master branch:

ChainRulesCore.jl/src/tangent_types/tangent.jl

Line 68 in 8ec9e20

function Base.:(==)(a::Tangent{P}, b::Tangent{P}) where {P}

[oxinabox]

None of those exist on the master branch. So I am guessing must be a old version

[mcabbott]

Sorry, I can't reconstruct but agree I must have got an old version somewhere.