Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link in docs for Thunk #559

Closed
oscardssmith opened this issue Jun 28, 2022 · 1 comment · Fixed by #560
Closed

Broken link in docs for Thunk #559

oscardssmith opened this issue Jun 28, 2022 · 1 comment · Fixed by #560

Comments

@oscardssmith
Copy link
Member

oscardssmith commented Jun 28, 2022

The repl documentation for ChainRulesCore.Thunk links to http://www.juliadiff.org/ChainRulesCore.jl/dev/writing_good_rules.html#Use-Thunks-appropriately-1 which doesn't exist. It should instead link to https://juliadiff.org/ChainRulesCore.jl/dev/rule_author/writing_good_rules.html

@devmotion
Copy link
Member

It should instead link to https://juliadiff.org/ChainRulesCore.jl/dev/rule_author/writing_good_rules.html

Or maybe rather https://juliadiff.org/ChainRulesCore.jl/dev/rule_author/writing_good_rules.html#Use-Thunks-appropriately ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants