Make @opt_out rrule(...) automatically qualify rrule namespace as ChainRulesCore.rrule
#546
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #546 +/- ##
==========================================
+ Coverage 93.41% 93.45% +0.04%
==========================================
Files 15 15
Lines 865 871 +6
==========================================
+ Hits 808 814 +6
Misses 57 57
Continue to review full report at Codecov.
|
This claim is to strong, there is still all kinds of evil 😂 But more seriously for our own future reference it would be good for this PR to have clearer title and description. As i understand it the core of the problem was if the name |
src/rule_definition_tools.jl
Outdated
| return if call_target == :rrule | ||
| _target_rewrite!(qt::QuoteNode, rule_norule) = _target_rewrite!(qt.value, rule_norule) | ||
| function _target_rewrite!(call_target::Symbol, rule_norule) | ||
| return if call_target == :rrule && rule_norule == :norule | ||
| :(ChainRulesCore.no_rrule) |
There was a problem hiding this comment.
I think
| :(ChainRulesCore.no_rrule) | |
| :($ChainRulesCore.no_rrule) |
might work to actually make this function even if the module name ChainRulesCore isn't in the caller's scope.
If it does then these test could be moved to the isolated macro testing module.
(or a similar setup could be made for this file for testing purposes)
See the setup in
https://github.com/JuliaDiff/ChainRulesCore.jl/blob/main/test/rule_definition_tools.jl#L286
Co-authored-by: Frames Catherine White <[email protected]>
mzgubic
changed the title
@opt_out not evil@opt_out rrule(...) automatically qualify rrule namespace as ChainRulesCore.rrule
Closes #545