Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

== method ambiguities with Base julia #540

Closed
rafaqz opened this issue Feb 16, 2022 · 3 comments
Closed

== method ambiguities with Base julia #540

rafaqz opened this issue Feb 16, 2022 · 3 comments

Comments

@rafaqz
Copy link

rafaqz commented Feb 16, 2022

== with an Any argument is ambiguous with == on Missing and WeakRef. Maybe specific methods for those types can be added here for AbstractThunk?

Otherwise Aqua.jl ambiguity testing is broken for all dependent packages.

See:
SimonDanisch/AbstractNumbers.jl#16
with CI breaking for ChainRulesCore ambiguities here:
https://github.com/SimonDanisch/AbstractNumbers.jl/runs/5208526811?check_suite_focus=true#step:5:106

@devmotion
Copy link
Member

Otherwise Aqua.jl ambiguity testing is broken for all dependent packages.

You can specify recursive=false to only check ambiguities in your packages: https://juliatesting.github.io/Aqua.jl/dev/#Aqua.test_ambiguities-Tuple{Any}

@rafaqz
Copy link
Author

rafaqz commented Feb 19, 2022

Unfortunately that doesn't seem to work. But you can use exclude=[(==)] instead.

@nsajko
Copy link
Contributor

nsajko commented May 29, 2024

Neither Aqua.test_all(ChainRulesCore) nor detect_ambiguities(ChainRulesCore, recursive=true) show == as ambiguous any more, although there are other ambiguous methods. So I guess this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants