implement projection for InplaceableThunk
#541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #541 +/- ##
==========================================
- Coverage 93.41% 86.75% -6.66%
==========================================
Files 15 14 -1
Lines 865 687 -178
==========================================
- Hits 808 596 -212
- Misses 57 91 +34
Continue to review full report at Codecov.
|
|
This is fine by me. But I think @oxinabox objected to this the first time around. |
oxinabox
reviewed
Feb 18, 2022
oxinabox
approved these changes
Feb 18, 2022
Co-authored-by: Frames Catherine White <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #538