Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix projecting Tangent{Complex} to Number #535

Merged
merged 1 commit into from
Jan 20, 2022
Merged

fix projecting Tangent{Complex} to Number #535

merged 1 commit into from
Jan 20, 2022

Conversation

mzgubic
Copy link
Member

@mzgubic mzgubic commented Jan 17, 2022

Closes #531

@mzgubic mzgubic changed the title fix projecting Tangent{Complex} to Number fix projecting Tangent{Complex} to Number Jan 17, 2022
@mzgubic mzgubic force-pushed the mz/project_to_numbers branch from ec0cd74 to 64b629b Compare January 18, 2022 08:56
@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022 •
edited
Loading

Codecov Report

Merging #535 (64b629b) into main (95612d0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   93.40%   93.40%           
=======================================
  Files          15       15           
  Lines         864      864           
=======================================
  Hits          807      807           
  Misses         57       57
Impacted Files Coverage Δ
src/projection.jl 97.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95612d0...64b629b. Read the comment docs.

@mzgubic mzgubic requested a review from mcabbott January 18, 2022 12:20
@mzgubic mzgubic merged commit 699e61f into main Jan 20, 2022
@mzgubic mzgubic deleted the mz/project_to_numbers branch January 20, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcabbott mcabbott mcabbott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Projecting a Tangent{Complex} to Numbers
3 participants
@mzgubic @codecov-commenter @mcabbott