Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental ReverseDiff support #123

Closed
wants to merge 3 commits into from
Closed

Experimental ReverseDiff support #123

wants to merge 3 commits into from

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Sep 14, 2023

Partial answer to #46

Problems:

  • Because of Add ChainRulesCore RuleConfig? JuliaDiff/ReverseDiff.jl#238, I was forced to dispatch the default rrule (with no RuleConfig) onto ReverseDiff, which seems arbitrary
  • Computing jacobians in the precompilation step of the ReverseDiff extension kills Julia brutally (it works in normal code)
  • ReverseDiff errors when byproducts are returned, and I don't know how to fix that

Ping @mohamed82008 for help

@gdalle
Copy link
Member Author

gdalle commented Oct 5, 2023

Gentle bump @mohamed82008 if you have comments to spare

@mohamed82008
Copy link
Collaborator

I won't have a chance to look into this for the next 3 weeks unfortunately.

@gdalle
Copy link
Member Author

gdalle commented Oct 5, 2023

OK no worries, it's low priority

@gdalle
Copy link
Member Author

gdalle commented Feb 9, 2024

@mohamed82008 I'd love your take on this one if you have some time. I recently started using ReverseDiff more and I rather like it!

@mohamed82008
Copy link
Collaborator

I have a deadline in a few days and a queue of people to get back to. I will take a look but probably won't be in the coming week.

@gdalle
Copy link
Member Author

gdalle commented Feb 9, 2024

No worries!

@gdalle gdalle closed this Apr 9, 2024
@gdalle gdalle deleted the gd/reversediff branch May 6, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants