Skip to content
This repository was archived by the owner on May 5, 2019. It is now read-only.

Commit f047cd2

Browse files
cjprybolnalimilan
authored andcommitted
Update combine to use splat ... style vcat, like in Base.vcat
This change is helpful to support changing vcat to be more consistent with Base.vcat, where passing an array is not allowed.
1 parent b953575 commit f047cd2

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/groupeddatatable/grouping.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ combine(map(d -> mean(dropnull(d[:c])), gd))
193193
"""
194194
function combine(ga::GroupApplied)
195195
gd, vals = ga.gd, ga.vals
196-
valscat = vcat(vals)
196+
valscat = vcat(vals...)
197197
idx = Vector{Int}(size(valscat, 1))
198198
j = 0
199199
@inbounds for (start, val) in zip(gd.starts, vals)

test/grouping.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ module TestGrouping
146146
groupby(dt, [:v1, :v2])
147147

148148
dt2 = by(e->1, DataTable(x=Int64[]), :x)
149-
@test size(dt2) == (0,1)
149+
@test size(dt2) == (0,2)
150150
@test isequal(sum(dt2[:x]), Nullable(0))
151151

152152
# Check that reordering levels does not confuse groupby

0 commit comments

Comments
 (0)