handle proper quotient of proper statespace systems #906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a method of
$$G_2 G_1^{-1}$$ $G_1^{-1}$ s non-proper and naive inversion fails, but the quotient $G_2 G_1^{-1}$ is proper and can be represented as a statespace system.
/
between two statespace systemsthat handles situations in which
The intermediate result is a descriptor system with non-identity and singular mass matrix
Ei
which is immediately simplified usingMatrixPencils.lsminreal
into a descriptor system with invertible mass matrix (if possible). This system is in turn simplified to have unit mass matrix. If the quotient isn't proper, at least one of the steps above will fail and throw an errorThe system sys2 is not invertible
.The call to
lsminreal
will generally lead to a smaller realization compared to what was returned before. This is the reason the testwas changed to compare the H-infnorm, we now return a second-order system instead of 4:th order.