Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove dependency on OpenPolicyAgent_jll #17

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Conversation

tanmaykm
Copy link
Member

Removing hard dependency on OpenPolicyAgent_jll. Since we allow caller to specify an opa executable, not having a tight dependency will allow calling code to avoid installing the jll at all. So that it will not be affected if the jll is not updated/outdated.

fixes: #15

Removing hard dependency on `OpenPolicyAgent_jll`. Since we allow caller to specify an opa executable, not having a tight dependency will allow calling code to avoid installing the jll at all. So that it will not be affected if the jll is not updated/outdated.
@tanmaykm tanmaykm requested review from a team and mortenpi October 28, 2024 09:36
@tanmaykm
Copy link
Member Author

Updated to require the opa executable command to be provided explicitly. It won't be picked up from PATH env anymore. Ref: #15 (comment)

specs/cli/gencli.jl Outdated Show resolved Hide resolved
src/cli/cli.jl Outdated Show resolved Hide resolved
src/server/server.jl Outdated Show resolved Hide resolved
src/server/server.jl Show resolved Hide resolved
@tanmaykm tanmaykm requested a review from mortenpi October 29, 2024 08:08
Copy link
Member

@mortenpi mortenpi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tanmaykm tanmaykm merged commit 792c578 into main Oct 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple package from OPA jll?
2 participants