Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework of temporal sampling #91

Open
Datseris opened this issue Mar 1, 2022 · 0 comments
Open

rework of temporal sampling #91

Datseris opened this issue Mar 1, 2022 · 0 comments
Labels
breaking This will introduce a breaking change hard This is definitely difficult to solve! temporal Related with the Time dimension

Comments

@Datseris
Copy link
Member

Datseris commented Mar 1, 2022

I think we can rework the source code that handles temporal sampling, to return units that are multiples of existing Julia types. E.g. Hour(1) for hourly sampling, Day(1) for daily, Hour(3) for 3-hourly sampling, etc. This will not only bring more type stability, but also reduce amount of source code as well allow naturally handling arbitrary multiples of such samplings, such as weekly Day(7), or centurial Year(100).

@Datseris Datseris added hard This is definitely difficult to solve! breaking This will introduce a breaking change temporal Related with the Time dimension labels Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking This will introduce a breaking change hard This is definitely difficult to solve! temporal Related with the Time dimension
Projects
None yet
Development

No branches or pull requests

1 participant