Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong sysimage for different julia command #136

Open
hexaeder opened this issue Jul 5, 2021 · 1 comment
Open

wrong sysimage for different julia command #136

hexaeder opened this issue Jul 5, 2021 · 1 comment

Comments

@hexaeder
Copy link

hexaeder commented Jul 5, 2021

Hey! First of all, thanks for providing this nice package, it makes comparing of several commits really easy :)

I've tried to judge benchmarks for several julia versions. Unfortunately, this does not work due to

juliacmd = benchmarkconfig.juliacmd
juliacmd = `$(Base.julia_cmd(juliacmd[1])) $color $(juliacmd[2:end])`

which takes the sysimage from the parent process.

julia> Base.julia_cmd(`julia-1.5`)
`julia-1.5 -Cnative -J/Applications/Julia-1.6.app/Contents/Resources/julia/lib/julia/sys.dylib -g1`

I'd argue, that a user supplied command should be taken as is without changes which depend on the parent command whatsoever.
Maybe it would be better to default the juliacmd in BenchmarkConfig to Base.julia_cmd() and just do

 juliacmd = benchmarkconfig.juliacmd 

in the actual benchmark function?

@KristofferC
Copy link
Collaborator

and just do

juliacmd = benchmarkconfig.juliacmd

I think that is how it used to work 4113fe2#diff-21450190f4a3f8e55d48c877d0c9aba737cc12fb8c74afaa3cd28f3283669682L244 but it was changed. cc @omus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants