Documenter update #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
abhro
commented
Jun 15, 2024
abhro
commented
- Update Documenter.jl versions
- Rerun benchmarks
- Refresh Manifest.toml
- Move large docstring to doc page
Documenter v0.25 uses Formatting.jl, which has serious correctness issues. Upgrade to 0.27 and remove compat with v0.25
The string on its own is heavy and cumbersome, and better use can be made by having it in a standalone markdown file as part of the docs website.
- Double bars mean the norm, not the square-norm, so include it within the squares. - Clarify that the HWHM is used in Moffat - Use −α as the exponent for formatting clarity and look like existing literature
Plot colorbar can't be sufficiently tweaked at this moment
|
Failing tests are from lack of compat for Statistics.jl, resolved in #17, and failure to deploy (permission issues) |
|
Deplyment key updated: http://juliaastro.org/PSFModels.jl/dev/ |
giordano
reviewed
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.