Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the checked_dims implementation to a dependency package? #89

Open
nsajko opened this issue Jan 14, 2025 · 1 comment · May be fixed by #90
Open

move the checked_dims implementation to a dependency package? #89

nsajko opened this issue Jan 14, 2025 · 1 comment · May be fixed by #90

Comments

@nsajko
Copy link
Collaborator

nsajko commented Jan 14, 2025

The functionality is required for all packages that require dense in-memory arrays, I think. There's also a Julia feature request to provide the functionality with Base: JuliaLang/julia#54327. Why not just make a small package for this? Here's a proposal, I'll add permissions to the two of you and request a move to JuliaArrays: https://github.com/nsajko/CheckedSizeProduct.jl EDIT: moved to https://github.com/JuliaArrays/CheckedSizeProduct.jl

Furthermore, AFAIK checked_dims is the only piece of implementation that FixedSizeBitArray shares with FixedSizeArray, so, assuming collect_as also becomes owned by another package, FixedSizeBitArrays.jl seems like it could stand on its own as yet another package. Cross-referencing PR #75.

@nsajko

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant