Add a BroadcastStyle
for AbstractFill
#385
Draft
+218
−97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40
Fixes #58
Fixes #143
Fixes #145
Fixes #188
After this,
A special
ZerosStyle
is necessary to properly handle broadcasting with structured matrix types fromLinearAlgebra
.Often, we will have
AbstractFill
return types returned now in broadcasting operations, and --- where possible --- ones whose values are statically known:This does not change the fact that broadcasting over a
Fill
is evaluated before others in a fused broadcast:This is achieved by recursively walking through a
Broadcasted
object, and evaluating the components that produceAbstractFill
s eagerly.