tuning scalar multiplication

[kalmarek]

@blegat

[codecov]

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.26%. Comparing base (f998c9f) to head (7a0232e).

Files	Patch %	Lines
src/coefficients.jl	92.85%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   86.23%   86.26%   +0.02%     
==========================================
  Files          14       14              
  Lines         741      757      +16     
==========================================
+ Hits          639      653      +14     
- Misses        102      104       +2     

Flag	Coverage Δ
unittests	86.26% <96.29%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blegat]

It's maybe cleaner to do something like

"""
    lmul(a, X)
Multiplies the coefficients of `X` by `a`.
"""
function lmul end
function lmul(a, X::AlgebraElement)
    return MA.operate_to(similar(X), lmul, a, X)
end
Base.:*(a, X::AlgebraEleemnt) = lmul(a, X)

where lmul would be an explicit way to multiply the coefficients (I'm open to other names, in MP, I call it left_constant_mult I think but we don't have to use the same name)

[kalmarek]

I'm not sure it changes much, I don't intend these functions to be used by anyone outside ;)

[kalmarek]

It's maybe cleaner to do something like

"""
    lmul(a, X)
Multiplies the coefficients of `X` by `a`.
"""
function lmul end
function lmul(a, X::AlgebraElement)
    return MA.operate_to(similar(X), lmul, a, X)
end
Base.:*(a, X::AlgebraEleemnt) = lmul(a, X)

where lmul would be an explicit way to multiply the coefficients (I'm open to other names, in MP, I call it left_constant_mult I think but we don't have to use the same name)

It serves precisely the opposite role, where the coefficients stay the same and we shift keys ;)

[blegat]

There is some added allocation on nightly but it might be due to a change in Julia since yesterday

[kalmarek]

Since you approved, fixing nightly is on you from now on :D