Fix rrule for * and add support for constant operations #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mitchell Harris <[email protected]>
blegat
commented
Dec 26, 2022
| #ΔΩ = ChainRulesCore.unthunk(Ω̇) | ||
| #return (ChainRulesCore.NoTangent(), ChainRulesCore.ProjectTo(p)(ΔΩ * q'), ChainRulesCore.ProjectTo(q)(p' * ΔΩ)) | ||
| return (ChainRulesCore.NoTangent(), ΔΩ̇ * q', p' * ΔΩ̇) | ||
| return (ChainRulesCore.NoTangent(), adjoint_mult_right(q, ΔΩ̇), adjoint_mult_left(p, ΔΩ̇)) |
There was a problem hiding this comment.
The previous definition was correct for the scalar product dot(p, q) = p * q, the current one is correct for the scalar product dot(p, q) = dot(coefficients(p), coefficients(q)) (assuming they have the same monomials).
There was a problem hiding this comment.
This second scalar product corresponds to the _dot we use for testing differentiate. This means that for differentiate we assume the other scalar product
blegat
force-pushed
the
bl/chain_rule_constant
branch
2 times, most recently
from
4ecd160
to
15315c8
Compare
blegat
force-pushed
the
bl/chain_rule_constant
branch
from
15315c8
to
2c3df71
Compare
|
@oxinabox this is the issue I mentioned to you at JuliaCon |
|
@sethaxen might have thoughts here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am a bit unsure what to do here. I think we should define
rrulebased onLinearAlgebra.dotso we should remove the definition of the rule fordifferentiateand keep the old one for*.@harris-mit I would expect that the current rule for differentitation gives incorrect result when you use it with AD since it assumes a scalar product that is not what is used, does it work for you ?