Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add InSample resampling strategy #975

Merged
merged 3 commits into from
May 6, 2024
Merged

Add InSample resampling strategy #975

merged 3 commits into from
May 6, 2024

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Apr 24, 2024 •
edited
Loading

Closes #967

To do post-PR:

  • re-export InSample from MLJ? (tracked)

@ablaom ablaom mentioned this pull request Apr 30, 2024
Closed
1 task
OkonSamuel
OkonSamuel reviewed May 5, 2024
View reviewed changes
src/resampling.jl Outdated Show resolved Hide resolved
OkonSamuel
OkonSamuel approved these changes May 5, 2024
View reviewed changes
Copy link
Member

@OkonSamuel OkonSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment. Asides that LGTM!!.

@ablaom
Copy link
Member Author

ablaom commented May 6, 2024

Thankyou @OkonSamuel for your review.

@ablaom ablaom merged commit d6b1930 into dev May 6, 2024
3 checks passed
@ablaom ablaom deleted the insample-evaluations branch May 6, 2024 01:10
This was referenced May 6, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OkonSamuel OkonSamuel OkonSamuel approved these changes

Assignees

@OkonSamuel OkonSamuel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add InSample resampling strategy
2 participants
@ablaom @OkonSamuel