Skip to content

Paginator doesn't have accessor methods for page params #365

@jaimeiniesta

Description

@jaimeiniesta

The README suggests the following can be done to customize the page parameters:

JsonApiClient::Paginating::Paginator.page_param = "number"
JsonApiClient::Paginating::Paginator.per_page_param = "size"

However, this fails because this paginator doesn't have accessor methods for these attributes:

/Users/jaime/.rvm/gems/ruby-2.3.7/gems/json_api_client-1.16.1/lib/json_api_client/paginating/paginator.rb:4:in `<class:Paginator>': undefined method `class_attribute' for JsonApiClient::Paginating::Paginator:Class (NoMethodError)
Did you mean?  class_variables
               class_variable_get
               class_variable_set
               class
               alias_attribute
        from /Users/jaime/.rvm/gems/ruby-2.3.7/gems/json_api_client-1.16.1/lib/json_api_client/paginating/paginator.rb:3:in `<module:Paginating>'
        from /Users/jaime/.rvm/gems/ruby-2.3.7/gems/json_api_client-1.16.1/lib/json_api_client/paginating/paginator.rb:2:in `<module:JsonApiClient>'
        from /Users/jaime/.rvm/gems/ruby-2.3.7/gems/json_api_client-1.16.1/lib/json_api_client/paginating/paginator.rb:1:in `<top (required)>'

The other paginator, NestedParamPaginator, does work can be customized like:

JsonApiClient::Paginating::NestedParamPaginator.page_param = "number"
JsonApiClient::Paginating::NestedParamPaginator.per_page_param = "size"

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions