Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[USERSNAP] Proposals: Activity feed is always out of date #3125

Open
dmtrjsg opened this issue May 30, 2022 · 6 comments
Open

[USERSNAP] Proposals: Activity feed is always out of date #3125

dmtrjsg opened this issue May 30, 2022 · 6 comments
Assignees
Labels
bug Something isn't working community-dev issue suitable for community-dev pipeline qa-task qa-tests-failed scope:proposals The "Proposals" page and related features SP:3

Comments

@dmtrjsg
Copy link
Contributor

dmtrjsg commented May 30, 2022

Taken at: https://dao.joystream.org/#/proposals/past
Fields:

  • Houston, we have a problem.: Proposals: Activity feed is always out of date
  • Comment: SSIA
    Its a very weird problem because it always seems to be out of date by some number of days yet still works?
  • Feedback: tomato#9464

SCREENSHOT
Download original image

Browser: Chrome 101 (Windows 10)
Screen size: 3440x1440
Browser size: 1713x1050
Open #267 in Usersnap

Powered by Usersnap.

@dmtrjsg dmtrjsg added the bug Something isn't working label May 30, 2022
@dmtrjsg dmtrjsg self-assigned this May 30, 2022
@dmtrjsg dmtrjsg added to-triage scope:proposals The "Proposals" page and related features community-dev issue suitable for community-dev pipeline and removed to-triage labels Jun 6, 2022
@dmtrjsg dmtrjsg added the SP:3 label Jun 9, 2022
@singulart
Copy link
Contributor

In progress by @lucky-gru since Sep 7, 2022

@singulart
Copy link
Contributor

Moved back to To-Do

@singulart
Copy link
Contributor

in progress by mkblockchaindev since Sep 27th

@singulart
Copy link
Contributor

Query executed:

query GetProposalsEvents {
  events(
    where: {type_in: [ProposalCreatedEvent, ProposalStatusUpdatedEvent, ProposalDecisionMadeEvent, ProposalCancelledEvent, ProposalDiscussionThreadModeChangedEvent, ProposalExecutedEvent, ProposalVotedEvent, ProposalDiscussionPostCreatedEvent, ProposalDiscussionPostUpdatedEvent, ProposalDiscussionPostDeletedEvent]}
    orderBy: [createdAt_DESC]
  ) {
    ... on ProposalCreatedEvent {
      ...ProposalCreatedEventFields
      __typename
    }
    ... on ProposalCancelledEvent {
      ...ProposalCancelledEventFields
      __typename
    }
    ... on ProposalStatusUpdatedEvent {
      ...ProposalStatusUpdatedEventFields
      __typename
    }
    ... on ProposalDecisionMadeEvent {
      ...ProposalDecisionMadeEventFields
      __typename
    }
    ... on ProposalDiscussionThreadModeChangedEvent {
      ...ProposalDiscussionModeChangedEventFields
      __typename
    }
    ... on ProposalExecutedEvent {
      ...ProposalExecutedEventFields
      __typename
    }
    ... on ProposalVotedEvent {
      ...ProposalVotedEventFields
      __typename
    }
    ... on ProposalDiscussionPostCreatedEvent {
      ...ProposalDiscussionPostCreatedEventFields
      __typename
    }
    ... on ProposalDiscussionPostUpdatedEvent {
      ...ProposalDiscussionPostUpdatedEventFields
      __typename
    }
    ... on ProposalDiscussionPostDeletedEvent {
      ...ProposalDiscussionPostDeletedEventFields
      __typename
    }
    __typename
  }
}

fragment ProposalCreatedEventFields on ProposalCreatedEvent {
  id
  createdAt
  proposal {
    id
    title
    creator {
      id
      handle
      __typename
    }
    __typename
  }
  __typename
}

fragment ProposalCancelledEventFields on ProposalCancelledEvent {
  id
  createdAt
  proposal {
    id
    title
    creator {
      id
      handle
      __typename
    }
    __typename
  }
  __typename
}

fragment ProposalStatusUpdatedEventFields on ProposalStatusUpdatedEvent {
  id
  createdAt
  proposal {
    id
    title
    __typename
  }
  newStatus {
    __typename
  }
  __typename
}

fragment ProposalDecisionMadeEventFields on ProposalDecisionMadeEvent {
  id
  createdAt
  proposal {
    id
    title
    __typename
  }
  __typename
}

fragment ProposalDiscussionModeChangedEventFields on ProposalDiscussionThreadModeChangedEvent {
  id
  createdAt
  thread {
    proposal {
      id
      title
      __typename
    }
    __typename
  }
  newMode {
    __typename
  }
  __typename
}

fragment ProposalExecutedEventFields on ProposalExecutedEvent {
  id
  createdAt
  proposal {
    id
    title
    __typename
  }
  executionStatus {
    __typename
  }
  __typename
}

fragment ProposalVotedEventFields on ProposalVotedEvent {
  id
  createdAt
  proposal {
    id
    title
    __typename
  }
  voter {
    id
    handle
    __typename
  }
  __typename
}

fragment ProposalDiscussionPostCreatedEventFields on ProposalDiscussionPostCreatedEvent {
  id
  createdAt
  post {
    id
    author {
      id
      handle
      __typename
    }
    discussionThread {
      proposal {
        id
        title
        __typename
      }
      __typename
    }
    __typename
  }
  __typename
}

fragment ProposalDiscussionPostUpdatedEventFields on ProposalDiscussionPostUpdatedEvent {
  id
  createdAt
  post {
    id
    author {
      id
      handle
      __typename
    }
    discussionThread {
      proposal {
        id
        title
        __typename
      }
      __typename
    }
    __typename
  }
  __typename
}

fragment ProposalDiscussionPostDeletedEventFields on ProposalDiscussionPostDeletedEvent {
  id
  createdAt
  post {
    id
    author {
      id
      handle
      __typename
    }
    discussionThread {
      proposal {
        id
        title
        __typename
      }
      __typename
    }
    __typename
  }
  __typename
}

@chrlschwb
Copy link
Contributor

Joystream/hydra#509

this PR seems to fix this issue

@ivanturlakov
Copy link

Tested on https://dao-git-dev-joystream.vercel.app/#/proposals/past
wss://34.230.5.182.nip.io/ws-rpc

Actions:

  • Proposal ID:117 Created,
  • Added 2 comments,
  • Proposal voted

⚠️ There is no msg about proposal creation in the activity feed
Снимок экрана 2023-02-10 в 13 26 02

⚠️ Disorder of status update
Снимок экрана 2023-02-10 в 13 44 58
Снимок экрана 2023-02-10 в 13 44 43

Tested on https://pioneerapp.xyz/#/proposals/current

⚠️ Proposals 123, 124 were voted on and changed status, but there is no msgs in the activity feed

Снимок экрана 2023-02-10 в 13 19 23

Снимок экрана 2023-02-10 в 13 19 50

Снимок экрана 2023-02-10 в 13 20 34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working community-dev issue suitable for community-dev pipeline qa-task qa-tests-failed scope:proposals The "Proposals" page and related features SP:3
Projects
None yet
Development

No branches or pull requests

5 participants