Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links to posts depend on their page number #1312

Closed
thesan opened this issue Sep 2, 2021 · 0 comments · Fixed by #1358
Closed

Links to posts depend on their page number #1312

thesan opened this issue Sep 2, 2021 · 0 comments · Fixed by #1358
Assignees
@thesan
Labels
bug Something isn't working scope:forum The "Forum" page and related features
Milestone
Forum

Comments

@thesan
Copy link
Member

thesan commented Sep 2, 2021 •
edited
Loading

Given a post id and a thread id, this link: /forum/thread}/:threadId/post=postId will not work if the targeted post is not on the first page.
Which is problematic when linking a post matching a search in #1309
@thesan thesan added bug Something isn't working scope:forum The "Forum" page and related features labels Sep 2, 2021
@thesan thesan added this to the Forum milestone Sep 2, 2021
@thesan thesan self-assigned this Sep 2, 2021
@thesan thesan linked a pull request Sep 7, 2021 that will close this issue
⛓️ Link to any post from its id and thread id #1358
Merged
@thesan thesan mentioned this issue Sep 7, 2021
Merged
@thesan thesan closed this as completed Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thesan thesan

Labels
bug Something isn't working scope:forum The "Forum" page and related features
Projects
None yet
Milestone
Forum
Development

Successfully merging a pull request may close this issue.

⛓️ Link to any post from its id and thread id Joystream/pioneer
1 participant
@thesan