Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use utils.promisify(dns.lookup) as OpenTelemetey's DNS instrumentation can't patch such function properly #525

Open
zeeshanakram3 opened this issue Jul 13, 2023 · 0 comments
Open

Don't use utils.promisify(dns.lookup) as OpenTelemetey's DNS instrumentation can't patch such function properly #525

zeeshanakram3 opened this issue Jul 13, 2023 · 0 comments
Assignees
@zeeshanakram3
Labels
bug Something isn't working enhancement New feature or request

Comments

@zeeshanakram3
Copy link
Contributor

Context

Joystream/joystream#4779 (comment)

Fix

Make a change in the graphql-server codebase to use either callback based or dns/promise based lookup method instead of promisify lookup function
@zeeshanakram3 zeeshanakram3 added bug Something isn't working enhancement New feature or request labels Jul 13, 2023
@zeeshanakram3 zeeshanakram3 self-assigned this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zeeshanakram3 zeeshanakram3

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zeeshanakram3