Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation of CityBlockHash #7

Open
skoppula opened this issue Mar 26, 2016 · 1 comment
Open

Calculation of CityBlockHash #7

skoppula opened this issue Mar 26, 2016 · 1 comment

Comments

@skoppula
Copy link

In families/CityBlockHash.java, you calculate the hash with the following code (line 51):

hash[d] = (int) (vector.get(d)-randomPartition.get(d) / Double.valueOf(w));

I could be wrong here, but would you want parenthesis around the numerator? Otherwise order of operations takes precedence, which I'm not sure is correct.

Thanks. I'd be happy to put in a pull request for you, if need be.

@joyouskoala
Copy link
Contributor

I sent a pull request for this
#14
There is another problem there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants