diff --git a/commandapi-platforms/commandapi-velocity/commandapi-velocity-plugin/src/main/java/dev/jorel/commandapi/CommandAPIMain.java b/commandapi-platforms/commandapi-velocity/commandapi-velocity-plugin/src/main/java/dev/jorel/commandapi/CommandAPIMain.java index 7936a9875..3a3c5a54b 100644 --- a/commandapi-platforms/commandapi-velocity/commandapi-velocity-plugin/src/main/java/dev/jorel/commandapi/CommandAPIMain.java +++ b/commandapi-platforms/commandapi-velocity/commandapi-velocity-plugin/src/main/java/dev/jorel/commandapi/CommandAPIMain.java @@ -35,16 +35,17 @@ public CommandAPIMain(ProxyServer server, Logger logger, @DataDirectory Path dat // Try to find the config file Path configFile = dataDirectory.resolve("config.yml"); + YamlConfigurationLoader loader = YamlConfigurationLoader.builder() + .nodeStyle(NodeStyle.BLOCK) + .path(configFile) + .build(); + // Create or update config - VelocityConfigurationAdapter.createDummyInstance().saveDefaultConfig(configFile.getParent().toFile(), configFile.toFile(), logger); + VelocityConfigurationAdapter.createDummyInstance(loader).saveDefaultConfig(configFile.getParent().toFile(), configFile.toFile(), logger); // Load the file as a yaml node ConfigurationNode configYAML; try { - YamlConfigurationLoader loader = YamlConfigurationLoader.builder() - .nodeStyle(NodeStyle.BLOCK) - .path(configFile) - .build(); configYAML = loader.load(); } catch (IOException e) { throw new RuntimeException(e); diff --git a/commandapi-platforms/commandapi-velocity/commandapi-velocity-plugin/src/main/java/dev/jorel/commandapi/config/VelocityConfigurationAdapter.java b/commandapi-platforms/commandapi-velocity/commandapi-velocity-plugin/src/main/java/dev/jorel/commandapi/config/VelocityConfigurationAdapter.java index 22bfbfe80..4ea7db425 100644 --- a/commandapi-platforms/commandapi-velocity/commandapi-velocity-plugin/src/main/java/dev/jorel/commandapi/config/VelocityConfigurationAdapter.java +++ b/commandapi-platforms/commandapi-velocity/commandapi-velocity-plugin/src/main/java/dev/jorel/commandapi/config/VelocityConfigurationAdapter.java @@ -3,7 +3,6 @@ import org.spongepowered.configurate.CommentedConfigurationNode; import org.spongepowered.configurate.ConfigurationNode; import org.spongepowered.configurate.serialize.SerializationException; -import org.spongepowered.configurate.yaml.NodeStyle; import org.spongepowered.configurate.yaml.YamlConfigurationLoader; import java.io.File; @@ -14,8 +13,8 @@ public record VelocityConfigurationAdapter(YamlConfigurationLoader loader, CommentedConfigurationNode config, DefaultVelocityConfig defaultVelocityConfig) implements ConfigurationAdapter { - public static VelocityConfigurationAdapter createDummyInstance() { - return new VelocityConfigurationAdapter(null, null, null); + public static VelocityConfigurationAdapter createDummyInstance(YamlConfigurationLoader loader) { + return new VelocityConfigurationAdapter(loader, null, null); } @Override @@ -80,10 +79,6 @@ public ConfigurationAdapter createNew() { @Override public void saveDefaultConfig(File directory, File configFile, Logger logger) { - YamlConfigurationLoader configLoader = YamlConfigurationLoader.builder() - .nodeStyle(NodeStyle.BLOCK) - .file(configFile) - .build(); DefaultVelocityConfig defaultConfig = DefaultVelocityConfig.createDefault(); ConfigGenerator configGenerator = ConfigGenerator.createNew(defaultConfig); if (!directory.exists()) { @@ -92,9 +87,9 @@ public void saveDefaultConfig(File directory, File configFile, Logger logger) { logger.severe("Failed to create directory for the CommandAPI's config.yml file!"); } try { - ConfigurationAdapter velocityConfigurationAdapter = new VelocityConfigurationAdapter(configLoader, configLoader.createNode(), defaultConfig); + ConfigurationAdapter velocityConfigurationAdapter = new VelocityConfigurationAdapter(loader, loader.createNode(), defaultConfig); configGenerator.generate(velocityConfigurationAdapter); - configLoader.save(velocityConfigurationAdapter.config()); + loader.save(velocityConfigurationAdapter.config()); } catch (IOException e) { logger.severe("Could not create default config file! This is (probably) a bug."); logger.severe("Error message: " + e.getMessage()); @@ -106,11 +101,11 @@ public void saveDefaultConfig(File directory, File configFile, Logger logger) { } else { try { // If the config does exist, update it if necessary - CommentedConfigurationNode existingYamlConfig = configLoader.load(); - ConfigurationAdapter existingConfig = new VelocityConfigurationAdapter(configLoader, existingYamlConfig, defaultConfig); + CommentedConfigurationNode existingYamlConfig = loader.load(); + ConfigurationAdapter existingConfig = new VelocityConfigurationAdapter(loader, existingYamlConfig, defaultConfig); ConfigurationAdapter updatedConfig = configGenerator.generate(existingConfig); if (updatedConfig != null) { - configLoader.save(updatedConfig.config()); + loader.save(updatedConfig.config()); } } catch (IOException e) { logger.severe("Could not update config! This is (probably) a bug.");