Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further Resolving of Message Calls Within Functions #206

Open
Autosaida opened this issue Nov 28, 2023 · 5 comments · May be fixed by #507
Open

Further Resolving of Message Calls Within Functions #206

Autosaida opened this issue Nov 28, 2023 · 5 comments · May be fixed by #507
Assignees
Labels
A-core Area: core C-decompile Command: decompile C-snapshot Command: snapshot D-average Difficulty: average P-normal Priority: normal T-feature Type: feature

Comments

@Autosaida
Copy link

Component

Heimdall (Core)

Describe the feature you would like

The proposed improvement aims to enhance the decompilation functionality by providing a more detailed analysis of message calls within functions, specifically regarding call, staticcall, and delegatecall operations.

For example, considering the contract at address 0x9f00c43700bc0000Ff91bE00841F8e04c0495000 from the "examples", the current decompilation result is as follows:

(bool success, bytes memory ret0) = address(arg1).staticcall(abi.encode(0xa567a8fa00000000000000000000000000000000000000000000000000000000));

In the verify function of this contract, there is a staticcall. However, the function signature 0xa567a8fa can be found in the database as curtaPlayer(). Therefore, an ideal decompilation result might look like this:

(bool success, bytes memory ret0) = address(arg1).curtaPlayer();

I'm uncertain whether this idea is complete, and I welcome any feedback or suggestions.

Your contribution to this impressive project is highly appreciated.

@Autosaida Autosaida added the T-feature Type: feature label Nov 28, 2023
@Jon-Becker Jon-Becker added A-core Area: core C-decompile Command: decompile C-snapshot Command: snapshot D-average Difficulty: average P-normal Priority: normal good first issue Good for new contributors labels Nov 28, 2023
@Jon-Becker
Copy link
Owner

This is a great idea! I'll tackle if not taken soon :)

@Jon-Becker Jon-Becker self-assigned this Jan 1, 2024
@Jon-Becker
Copy link
Owner

up next

@Jon-Becker Jon-Becker removed the good first issue Good for new contributors label Jun 18, 2024
@ttttonyhe
Copy link

ttttonyhe commented Aug 13, 2024

@Jon-Becker Any updates on this? Thanks.

@Jon-Becker
Copy link
Owner

@Jon-Becker Any updates on this? Thanks.

sorry for the massive delay but yes, pr is in draft :)

@Jon-Becker
Copy link
Owner

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: core C-decompile Command: decompile C-snapshot Command: snapshot D-average Difficulty: average P-normal Priority: normal T-feature Type: feature
Projects
None yet
3 participants