Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not store the children of root skill #351

Open
elenadimitrova opened this issue Sep 12, 2018 · 1 comment
Open

Not store the children of root skill #351

elenadimitrova opened this issue Sep 12, 2018 · 1 comment
Labels
maintenance

Comments

@elenadimitrova
Copy link
Contributor

There are potentially some gas cost savings to be had from not adding the skill.children of the root skill as the children of that will always be all skills. See todo
@elenadimitrova elenadimitrova added this to the Sprint 13 milestone Oct 30, 2018
@elenadimitrova elenadimitrova removed this from the Sprint 13 milestone Nov 12, 2018
@elenadimitrova
Copy link
Contributor Author

addGlobalSkill costs ~278,608 gas and here we can save 25,000 or about 9% of that. However the additional logic needed for handling the root skill as a special case potentially out-weights this gas saving. Since this is non-essential for the Colony Contribute launch, we're iceboxing it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elenadimitrova