Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isDarkMode method is called too many times? #1

Open
KartikShrivastava opened this issue Sep 1, 2021 · 0 comments
Open

isDarkMode method is called too many times? #1

KartikShrivastava opened this issue Sep 1, 2021 · 0 comments

Comments

@KartikShrivastava
Copy link

Hi Johannes,

Thanks for this work. I'm a bit concerned about too many calls made to ThemeProvider.isDarkMode while testing it for web. It is being called 4 times whenever the switch is toggled, any comments on this?

Thanks,
Kartik
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KartikShrivastava