Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highcharts_Ext5 column chart draws twice #34

Open
Edvardoh opened this issue May 8, 2015 · 3 comments
Open

Highcharts_Ext5 column chart draws twice #34

Edvardoh opened this issue May 8, 2015 · 3 comments

Comments

@Edvardoh
Copy link
Collaborator

Edvardoh commented May 8, 2015

I've tried to work around this issue by overriding the _onResize function in Chart/ux/Highcharts.js, and listening to the resize event on a parent Ext panel, however the draw method would still get called twice each time the window was resized and when the chart was first rendered.

I suspect it's something in the column serie file, since I see the issue in your examples as well, but only for the column charts.

Please let me know if you have any workarounds for this.

Really appreciate your work!

  • Ed
@Edvardoh
Copy link
Collaborator Author

Ok, so I was able to implement a fix, I will create a pull request for it shortly and you can bring it in if you like.

All I did was wrap the call to this.refresh() at the end of the draw() method with an Ext.defer(). The defer defaults to 0 milliseconds, and the user can pass in a config called drawDefer {integer}, which will delay the call to the refresh function.

For my issue with the column series, passing in 1000 milliseconds prevents the double draw I was experiencing very well.

Let me know of any concerns.

@Edvardoh
Copy link
Collaborator Author

Realized I don't have permission to push up a new branch in this repo (makes sense). If you'd like to grant me access I can push up my fix - if you don't like it you can always reject it.

Cheers

@JoeKuan
Copy link
Owner

JoeKuan commented May 14, 2015

Thank you very much for your contribution. I will try to sort out github
later today and let you know.

Joe

On 14 May 2015 at 15:26, Ed Davis [email protected] wrote:

Realized I don't have permission to push up a new branch in this repo
(makes sense). If you'd like to grant me access I can push up my fix - if
you don't like it you can always reject it.

Cheers


Reply to this email directly or view it on GitHub
#34 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants