{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":752987108,"defaultBranch":"master","name":"node-coap","ownerLogin":"JimmyBjorklund","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2024-02-05T08:48:20.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/9413089?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1707122902.1811268","currentOid":""},"activityList":{"items":[{"before":"4f23b15deafe12eafa19ab4a1818fd7b0055120c","after":"f8be4f7208e316c9ff3523f17f94e0f6a98bf87e","ref":"refs/heads/master","pushedAt":"2024-05-28T07:15:17.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"JimmyBjorklund","name":"Jimmy Björklund","path":"/JimmyBjorklund","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9413089?s=80&v=4"},"commit":{"message":"Merge branch 'coapjs:master' into master","shortMessageHtmlLink":"Merge branch 'coapjs:master' into master"}},{"before":"23895168526f29b858a5c67771fa0ac493cc4b1c","after":"4f23b15deafe12eafa19ab4a1818fd7b0055120c","ref":"refs/heads/master","pushedAt":"2024-05-28T07:14:39.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"JimmyBjorklund","name":"Jimmy Björklund","path":"/JimmyBjorklund","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9413089?s=80&v=4"},"commit":{"message":"Fix blockwise response logic (#376)\n\n* Update blockwise tests to catch edge-cases\r\n\r\nUpdates the blockwise tests to catch the cases where the payload is\r\nsmaller than 'maxPacket', but the overall packet size after the headers\r\nare added exceeds 'maxPacket' which causes an error to be thrown.\r\n\r\nAlso adds checks to ensure that the response code is 2.05 for the tests\r\nthat require it, so 5.00 errors can't sneak through.\r\n\r\n* Update automatic blockwise transfer logic\r\n\r\nFix for blockwise transfer issues raised in #373 where a coap message\r\ncould avoid being split into blocks, yet still be larger than the\r\nallowable size of 1280 bytes. This applies the recommended maximum\r\npayload size from RFC 7252 Section 4.6 of 1024 bytes, and allows it to\r\nbe reduced in the config parameters as required.\r\n\r\nThe error that this fixes was introduced in\r\nd727d430d7c744a516d4c68d156ed6bf8262f7b7 and this attempts to keep the\r\nintent behind that commit, whilst fixing the technical flaws that it\r\nintroduced.\r\n\r\nThe 'IP_MTU' constant has been renamed to 'MAX_PAYLOAD' to more\r\naccurately describe what the it represents. The 'maxPacketSize'\r\nparameter has also been renamed to 'maxPayloadSize' for the same\r\nreason.\r\n\r\nNote that the renaming of the parameter is a potentially breaking\r\nchange.\r\n\r\n* Perform extra checks on CoAP message size\r\n\r\nThis fixes the logic for checking the maximum CoAP message size. The\r\ncheck is actually performed in the coap-packet repository in a default\r\nparameter on the `generate()` function, however the default value is not\r\nappropriate for all (if any) cases.\r\n\r\nThe maximum size that a CoAP message can be is the IP MTU, minus the IP\r\nheader and  minus the UDP header. The value is not constant across all\r\nIP network stacks, so the CoAP specification recommends a maximum of 1152\r\nbytes for cases where it is not known. The only way to know for sure is\r\nMTU path discovery, which is way outside of the scope of the project.\r\n\r\nThis commit creates a parameter that allows the max packet size to be\r\nadjusted as a server parameter for cases where (for example) the server\r\nis running on a 6LoWPAN/Thread network and needs a lower maximum message\r\nsize.\r\n\r\nNote that the logic for enforcing the size is just to throw an error and\r\ncrash the server. However, since the maximum payload size is enforced a\r\nsituation like that should never occur.","shortMessageHtmlLink":"Fix blockwise response logic (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2045194186\" data-permission-text=\"Title is private\" data-url=\"https://github.com/coapjs/node-coap/issues/376\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/coapjs/node-coap/pull/376/hovercard\" href=\"https://github.com/coapjs/node-coap/pull/376\">coapjs#376</a>)"}},{"before":"7323526727aaf71cd54503dc694ce2819edc3336","after":"23895168526f29b858a5c67771fa0ac493cc4b1c","ref":"refs/heads/master","pushedAt":"2024-03-26T08:38:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"JimmyBjorklund","name":"Jimmy Björklund","path":"/JimmyBjorklund","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9413089?s=80&v=4"},"commit":{"message":"Try to force rebuild of merger","shortMessageHtmlLink":"Try to force rebuild of merger"}},{"before":"af1ba11e4670006b964d78fcdfe33844e22eab63","after":"7323526727aaf71cd54503dc694ce2819edc3336","ref":"refs/heads/master","pushedAt":"2024-02-07T07:54:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"JimmyBjorklund","name":"Jimmy Björklund","path":"/JimmyBjorklund","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9413089?s=80&v=4"},"commit":{"message":"Accroding to https://github.com/isaacs types is not to be used any more","shortMessageHtmlLink":"Accroding to <a href=\"https://github.com/isaacs\">https://github.com/isaacs</a> types is not to be used any more"}},{"before":"d3ae1197280830a522b559373be67c962bdd8aa5","after":"af1ba11e4670006b964d78fcdfe33844e22eab63","ref":"refs/heads/master","pushedAt":"2024-02-05T09:40:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"JimmyBjorklund","name":"Jimmy Björklund","path":"/JimmyBjorklund","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9413089?s=80&v=4"},"commit":{"message":"Fixed build issuee  can only be default-imported using the 'esModuleInterop' flag","shortMessageHtmlLink":"Fixed build issuee can only be default-imported using the 'esModuleIn…"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNS0yOFQwNzoxNToxNy4wMDAwMDBazwAAAARViBeL","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wNS0yOFQwNzoxNToxNy4wMDAwMDBazwAAAARViBeL","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wMi0wNVQwOTo0MDo1My4wMDAwMDBazwAAAAPyFamc"}},"title":"Activity · JimmyBjorklund/node-coap"}