Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hasher Matcher Actioner? #2

Open
Dcallies opened this issue Jul 24, 2024 · 2 comments
Open

Hasher Matcher Actioner? #2

Dcallies opened this issue Jul 24, 2024 · 2 comments

Comments

@Dcallies
Copy link

Hey @sbruens!

Congrats on the release!

I'd love to augment your matching solution to pull in the code from https://github.com/facebook/ThreatExchange/tree/main/python-threatexchange, specifically hasher-matcher-actioner. I think there are folks who could benefit, though it requires pulling in an external dependency.

We've recently started releasing HMA in docker images, and that might help manage the dependencies, since you can pin the versions.

Questions for you:

  1. Do you accept pull requests?
  2. If I can get a proof of concept with it working, would you be interested in pulling it into altitude?
@sbruens
Copy link
Collaborator

sbruens commented Jul 25, 2024

Hi @Dcallies!

Questions for you:

  1. Do you accept pull requests?

Yes, as long as you can accept the CLA.

  1. If I can get a proof of concept with it working, would you be interested in pulling it into altitude?

Also yes!


I just uploaded the WIP branch I had to replace the hashing, I think I mentioned it to you last time we spoke. It's the simplest to swap out. Take a look: https://github.com/Jigsaw-Code/altitude/compare/sbruens/hma.

I think that would be a good starting point. IIRC I simply copied the config from the HMA example, but that part needs work specifically the username/db/password, but also probably the STORAGE_IFACE_INSTANCE configuration? Let me know what you think!

@Dcallies
Copy link
Author

Awesome, thanks for the pointers, I might give it a try to see if I can connect the rest of the dots. Will keep you in the loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants