Case Files #46
Case Files #46
Conversation
|
TODO Assign a reviewer |
There was a problem hiding this comment.
It looks good overall.
Here I leave some comments and after a quick review of par file.
Besides the changes. Here are extra things might be worth mentioning.
- case insensitive
- comment with
# - regularization
- It could read variable like 1.0/${dt} if it's in the same section
- It could also set under [VELOCITY] to overwrite the default values
- Check par in logfile
- The whole par will be printed into the logfile
- The NekRS-recognized par key will be printed as
key: <name> value: <value>
Thanks
|
|
||
| .. code-block:: cpp | ||
|
|
||
| std::string user_occa_backend; | ||
| options.getArgs("THREAD MODEL", user_occa_backend); | ||
|
|
||
| In other words, if you have ``backend = CUDA`` in the ``.par`` file, then | ||
| As shown in snippet above, if you have ``backend = CUDA`` in the ``.par`` file, then |
There was a problem hiding this comment.
Only if such backend is enabled during the compile time
| ``user_occa_backend`` would be set to ``CUDA`` in the above code. | ||
|
|
||
| In the ``GENERAL`` section, key settings include configuring the simulation's polynomial | ||
| order (``polynomialOrder``), restart options, and time iteration parameters. For nekRS | ||
| simulations, a recommended polynomial order is ``p=7``, though the software currently |
There was a problem hiding this comment.
Is the notation consistent? Maybe need to work with theory?
Personally, I like
| In the ``GENERAL`` section, key settings include configuring the simulation's polynomial | ||
| order (``polynomialOrder``), restart options, and time iteration parameters. For nekRS | ||
| simulations, a recommended polynomial order is ``p=7``, though the software currently | ||
| supports orders ranging from 2 to 11. By default, nekRS uses the user-specified initial |
There was a problem hiding this comment.
I thought
| and ``checkpointInterval`` parameters. The user can specify this frequency based on | ||
| either a set number of time steps or a simulation time interval. | ||
| Additionally, the user can select the time-stepping order (i.e., the order of the | ||
| backward difference scheme for time discretization) by setting ``timeStepper`` |
There was a problem hiding this comment.
This sounds right, but it could be more precise? tombo3 is not BDF3 after all.
|
Does the sess file need to be given a brief introduction here/somewhere else? |
|
I have a few comments: Line 26: “With one optional file” Line 79: “* Line 133: “ |
|
@Tri2008 Could you put some of your findings regarding to |
|
Yes, I can do it |
To Close #28