Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for removing _ when using a union case with not data #428

Open
edgarfgp opened this issue Oct 12, 2022 · 3 comments
Open

Quick fix for removing _ when using a union case with not data #428

edgarfgp opened this issue Oct 12, 2022 · 3 comments

Comments

@edgarfgp
Copy link
Contributor

edgarfgp commented Oct 12, 2022

I recently fixed dotnet/fsharp#13851

type X = X

 let x: X = X

 let myVal =
     match x with
     | X _ -> ()

let myFunc(X x) = 5+5
 let myDiscardedArgFunc(X _)

This will not longer be valid and a new warning error will be reported : Pattern discard is not allowed for union case that takes no data.

Will Rider be affected by this change ?

Update : Im Rider user and I would love to contribute with some guidance to how to add a quick fix :)

@edgarfgp
Copy link
Contributor Author

edgarfgp commented Nov 16, 2022

@auduchinok Looks like this warning is now available on the EAP 8. and a code fix has been implemented in VS dotnet/fsharp#14267. Will this also be added for Rider 2022.3 stable?

@auduchinok
Copy link
Member

Update : Im Rider user and I would love to contribute with some guidance to how to add a quick fix :)

Great, let's have a chat on Slack? 🙂

@edgarfgp
Copy link
Contributor Author

Great, let's have a chat on Slack. ? 🙂

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants