Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compose sources. Remove redundant @OptIn of experimental annotations in the same module #3364

Closed
igordmn opened this issue Jul 18, 2023 · 2 comments · May be fixed by #4922
Closed

Compose sources. Remove redundant @OptIn of experimental annotations in the same module #3364

igordmn opened this issue Jul 18, 2023 · 2 comments · May be fixed by #4922
Labels
refactoring

Comments

@igordmn
Copy link
Collaborator

igordmn commented Jul 18, 2023 •
edited
Loading

After JetBrains/compose-multiplatform-core#687 it is no longer required.

We should remove it in all sourcesets, except commonMain, androidMain

Example:

// foundation module
@OptIn(ExperimentalFoundationApi::class) // it is no longer needed
class SomeClass


// material module
@OptIn(ExperimentalFoundationApi::class) // still needed (and shouldn't be used to keep backward compatibility)
class SomeClass
@igordmn igordmn changed the title Remove redundant @OptIn of experimental annotation in the same module Remove redundant @OptIn of experimental annotations in the same module Jul 18, 2023
@igordmn igordmn mentioned this issue Jul 18, 2023
Merged
@igordmn igordmn changed the title Remove redundant @OptIn of experimental annotations in the same module Compose sources. Remove redundant @OptIn of experimental annotations in the same module Jul 18, 2023
@SnehangshuChakraborty
Copy link

Taking a look into this

SnehangshuChakraborty added a commit to SnehangshuChakraborty/compose-multiplatform that referenced this issue Jun 3, 2024
@SnehangshuChakraborty
Remove redundant @OptIn of experimental annotations
c09ad1f 
## Proposed Change

Remove the annotation usage of ExperimentalComposeWebAPI from html core and integeration-core modules as this is no longer required

## Issues Fixed

Fixes: JetBrains#3364
Open
@okushnikov
Copy link
Collaborator

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

@JetBrains JetBrains locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redundant @OptIn of experimental annotations SnehangshuChakraborty/compose-multiplatform
3 participants
@igordmn @SnehangshuChakraborty @okushnikov