Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper files structure and common styling files. #33

Open
accakks opened this issue Apr 4, 2018 · 13 comments
Open

Proper files structure and common styling files. #33

accakks opened this issue Apr 4, 2018 · 13 comments

Comments

@accakks
Copy link

accakks commented Apr 4, 2018

No description provided.

@accakks
Copy link
Author

accakks commented Apr 4, 2018

  1. Every lesson can be put into folder of relevant subject instead of so many folders.
  2. Common styling files. Basic layout of lessons page is almost the same, so there can be a common css file which can be included again & again in every lesson code. Lesson specific styles can be in seperate file inside lesson folder.
  3. Bootstrap can be included from CDN & that maybe included in instructions in README or a basic template of index.html file can be suggested in some common folder (like the styling one)

These things would make project look more arranged & clean for so many people to work together!

@JessicaML
Copy link
Owner

good idea Aakanksha!

  1. Yes, for now 3 main folders for biology, chemistry, physics would be ideal, with topics and sub-topics lessons within them (see the lesson spreadsheet). https://docs.google.com/spreadsheets/d/1s-CqehOYRcrJmvR3d7WqAs7j7dDJLHuJlcRCXMLvwok/edit#gid=203115582

  2. There is already a lesson_template.css file inside css/lesson_template.css

  3. For bootstrap, the ideal is to have a CDN and also a local version to fall back on.

  4. We should be minifying files (e.g. JQuery) where possible too.

@JessicaML
Copy link
Owner

Shall I assign this task to you? ^^

@accakks
Copy link
Author

accakks commented Apr 6, 2018

Yes surely! :)
But it might take a little time as my colleges are going on!
If there's no hurry, I'd love to fix this one. 👍

@JessicaML
Copy link
Owner

JessicaML commented Apr 6, 2018 via email

@saloni-garg
Copy link

Yeah! @accakks that's indeed a great idea. Maybe I can help you with this.

@accakks
Copy link
Author

accakks commented Apr 14, 2018

Hi @saloni-garg Sure! :D Do you have any more suggestions to this?
We can discuss here & then start working on this together!

@JessicaML
Copy link
Owner

@accakks @saloni-garg Let's pause on this one - we are migrating the content to a rails/react app so we can wait til we are using that!

@accakks
Copy link
Author

accakks commented May 13, 2018

Sorry. I forgot this one. And yes, we can work on this after that. :)

@bhawna-singh
Copy link

@JessicaML can you please guide me and my partner @gargshruti30 a bit about the project as we would like to contribute towards the project ?!

@JessicaML
Copy link
Owner

Hello @bhawna-singh and @gargshruti30! Thanks for your interest! :D Shall we have a call so I can explain a little more about the project? Do you use Slack? You can join the slack channel here: https://join.slack.com/t/sciencemotions/shared_invite/enQtNTIyNDE4OTk1OTU1LThjYjRiMTBkNjkyNDQ1ZjZhNGEwNDFhNTE1NGZiZDllZDMwY2M4NTIyYzdhYTMwOGI3YTQ0MGJhMTFhM2YwNmU

@gargshruti30
Copy link

gargshruti30 commented Jan 13, 2019

@JessicaML I have joined the slack channel. I am looking forward to discussing this project with you.

@bhawna-singh
Copy link

bhawna-singh commented Jan 13, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants