-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link header-based paging #361
Comments
Your comment made me laugh and cry at the same time because it's so true. The lack of consistency in SendGrid's API is really astounding! There are so many gotchas and one thing that makes my head explode is that, no matter how many times you report these problems, SendGrid doesn't seem interested in fixing any of them. I reported issues 4-5 years ago and they still haven't been fixed. Even issues related to incorrect or incomplete documentation sometimes don't get fixed. I do my best to ensure that StrongGrid shields people from these inconsistencies and work around some of the problems and I honestly don't understand how people can tolerate interacting with this API using SendGrid's own client which forces every developer to deal with these issues. Anyway, enough ranting. Let's move on to addressing your question.
This is the first time I hear about this!?!?!?! I quickly searched the documentation and I can't find any mention of this I'm happy to add functionality to parse this I wonder if there are other endpoints in SendGrid's API that have this header?
It's very kind of you to offer sponsoring me, I appreciate it but at this time I am not looking to earn any revenue from the work I put into this library. My reward is when I realize that people benefit from my efforts. I get a lot more satisfaction from interacting with developers and hearing that my library helped them. Maybe some day the support burden will be too great and my opinion on sponsorship will change. If you want to help me in the short term, I am looking for assistance to spread the word about StrongGrid. Maybe you could write a blog post (if you have a blog) or write a testimonial in the discussions section? Maybe you could interact with other developers and introduce them to the library? I do this sometimes on SendGrid's repo but I am always afraid to be perceived negatively since I am promoting a project that I created. |
Here's my first draft: https://www.myget.org/feed/jericho/package/nuget/StrongGrid/0.76.0-paginated-respon0056 Let me konw what you think. |
@Jericho Hey, I work with @kevinchalet on this. In the RFC, |
ok, but you're assuming that SendGrid is implementing the RFC that you mentioned. I'm willing to invest the time and effort to implement a more robust |
@Jericho as I mentioned, they might not follow it. I just thought it would be better it doesn't crash in the core of your library if something were to differ slightly. |
I asked a question about this In the mean time I published a new version to my MyGet feed with a more robust parser that should conform to the RFC: https://www.myget.org/feed/jericho/package/nuget/StrongGrid/0.76.0-paginated-respon0062 |
Hey,
To make our lives more painful than they are, some SendGrid APIs - like global suppressions - use
Link
response headers instead of their usual_metadata
node to expose paging-related information. For instance, here's what thesuppression/unsubscribes
endpoint returns:Is there currently any way to access this response header using the typed client?
Off-topic: have you considered joining the GitHub Sponsors program? I enjoyed using StrongGrid in a project I worked on recently and I'd love to contribute back.
The text was updated successfully, but these errors were encountered: