From 2ce91ba28e49d2475c27da3f1ce2c977abf001fa Mon Sep 17 00:00:00 2001 From: DaniPopes <57450786+DaniPopes@users.noreply.github.com> Date: Sat, 11 Nov 2023 11:22:30 +0100 Subject: [PATCH] Lower MSRV to 1.65 The MSRV bump in https://github.com/JelteF/derive_more/pull/300 is unnecessary. The 1.72 minimum is only needed for tests, but the actual implementation depends on 1.65. --- .github/workflows/ci.yml | 5 ++--- CHANGELOG.md | 2 +- Cargo.toml | 2 +- README.md | 4 ++-- clippy.toml | 2 +- impl/Cargo.toml | 2 +- 6 files changed, 8 insertions(+), 9 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 778cb558..af55e52d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -54,7 +54,7 @@ jobs: strategy: fail-fast: false matrix: - msrv: ["1.72.0"] + msrv: ["1.65.0"] os: - ubuntu - macOS @@ -72,8 +72,7 @@ jobs: - name: Install minimal dependencies versions run: cargo +nightly update -Z minimal-versions - - run: cargo test --workspace --features full,testing-helpers - -- --skip compile_fail + - run: cargo build --workspace --features full no_std: runs-on: ubuntu-latest diff --git a/CHANGELOG.md b/CHANGELOG.md index 89ac783c..7bfac31b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,7 +10,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). ### Breaking changes -- The minimum supported Rust version (MSRV) is now Rust 1.72. +- The minimum supported Rust version (MSRV) is now Rust 1.65. - Add the `std` feature which should be disabled in `no_std` environments. - All Cargo features, except `std`, are now disabled by default. The `full` feature can be used to get the old behavior of supporting all possible diff --git a/Cargo.toml b/Cargo.toml index 6dd2b1e8..dd244ec9 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -2,7 +2,7 @@ name = "derive_more" version = "1.0.0-beta.6" edition = "2021" -rust-version = "1.72.0" +rust-version = "1.65.0" description = "Adds #[derive(x)] macros for more traits" authors = ["Jelte Fennema "] license = "MIT" diff --git a/README.md b/README.md index 324193bc..70344f64 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ [![Latest Version](https://img.shields.io/crates/v/derive_more.svg)](https://crates.io/crates/derive_more) [![Rust Documentation](https://docs.rs/derive_more/badge.svg)](https://docs.rs/derive_more) [![GitHub license](https://img.shields.io/badge/license-MIT-blue.svg)](https://raw.githubusercontent.com/JelteF/derive_more/master/LICENSE) -[![Rust 1.72+](https://img.shields.io/badge/rustc-1.72+-lightgray.svg)](https://blog.rust-lang.org/2023/08/24/Rust-1.72.0.html) +[![Rust 1.65+](https://img.shields.io/badge/rustc-1.65+-lightgray.svg)](https://blog.rust-lang.org/2023/08/24/Rust-1.65.0.html) [![Unsafe Forbidden](https://img.shields.io/badge/unsafe-forbidden-success.svg)](https://github.com/rust-secure-code/safety-dance) Rust has lots of builtin traits that are implemented for its basic types, such @@ -141,7 +141,7 @@ These don't derive traits, but derive static methods instead. ## Installation -This library requires Rust 1.72 or higher. To avoid redundant compilation times, by +This library requires Rust 1.65 or higher. To avoid redundant compilation times, by default no derives are supported. You have to enable each type of derive as a feature in `Cargo.toml`: diff --git a/clippy.toml b/clippy.toml index 0d86a7d2..0c697c31 100644 --- a/clippy.toml +++ b/clippy.toml @@ -2,7 +2,7 @@ # See full lints list at: # https://rust-lang.github.io/rust-clippy/master/index.html -msrv = "1.72.0" +msrv = "1.65.0" # Ensures consistent bracing for macro calls in the codebase. # Extends default settings: diff --git a/impl/Cargo.toml b/impl/Cargo.toml index c51136dd..548ee245 100644 --- a/impl/Cargo.toml +++ b/impl/Cargo.toml @@ -2,7 +2,7 @@ name = "derive_more-impl" version = "1.0.0-beta.6" edition = "2021" -rust-version = "1.72.0" +rust-version = "1.65.0" description = "Internal implementation of `derive_more` crate" authors = ["Jelte Fennema "] license = "MIT"