Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate user macros from curated example macro #437

Open
wdconinc opened this issue Jan 28, 2021 · 2 comments
Open

Separate user macros from curated example macro #437

wdconinc opened this issue Jan 28, 2021 · 2 comments

Comments

@wdconinc
Copy link
Member

Is your feature request related to a problem? Please describe.

New users of remoll are resorting to digging through the large number of macros in macros/. Not all of these macros are operational, or clearly written with the most up-to-date conventions. At the same time, we want to encourage everyone to keep their macros in the repository.

Describe the solution you'd like

We should have one directory with curate example macros which are part of the CI jobs (so they don't become stale). These macros should (therefore) run quickly. A separate directory should be used for user macros which are not guaranteed to work without some work.

So, the concrete proposal is

mkdir users/
mv macros/ users/macros
mkdir macros/

with only selected macros in macros/.

Describe alternatives you've considered

We could make sure all macros currently in macros/ run all the time. This would probably mean reducing the number of events to less than 100, and would mean fixing a number of macros that do not work at all anymore.

Additional information

A very similar situation is occuring in analysis/.

@wdconinc
Copy link
Member Author

@cipriangal @cameronc137 @rakithab Thoughts? You probably had recent students who encountered issues.

@cipriangal
Copy link
Contributor

I couldn't have said it better myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants