Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light guide length (very slightly) improperly calculated from PMT placement position parameter #3

Open
cameronc137 opened this issue Oct 3, 2019 · 0 comments

Comments

@cameronc137
Copy link
Contributor

In commit 233c075 there is the addition of a comment.

"the dzRef length computation also needs a dxRef*angle component (in this nomenclature it would be addition) so that the PMT placement in CAD solidworks will work out."

I don't remember exactly the problem, but I know that it has to do with a missing length*sin(small angle) shift, I think coming from the reflector opening angle being > 0 degrees

This issue is mostly to properly track my thoughts from a year ago so it eventually gets addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant