Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement (removeAlreadyWorkingOn(<Set>, <Channel>, <boolean>)) in "PropositionNode" #162

Open
ylkhayat opened this issue Apr 7, 2019 · 0 comments
Labels

Comments

@ylkhayat
Copy link

ylkhayat commented Apr 7, 2019

Two methods exist with the same functionality

  • removeAlreadyWorkingOn(NodeSet, Channel, boolean)

  • removeAlreadyWorkingOn(List<Match>, Channel, boolean)

Description
Instance method, called from the class it's implemented in as follows PropositionNode.removeAlreadyWorkingOn(nodes/matchingNodes, currentChannel, ruleType). What this function establishes is the following, filtering any given set/list nodes/matchingNodes to remove instances of them having previously handled a similar request (channel properties) as the one given through the input currentChannel.

We check such a thing by comparing the filter of the old requests to the fi lter of the current request, if the set of substitutions in any of them subsumes the substitutions set of the current one, then we are "already working on it". - Akram

Input

  • Channel

Return

  • boolean
@ylkhayat ylkhayat added the SNIP label Apr 9, 2019
@ylkhayat ylkhayat changed the title Implement (alreadyWorking(<Channel>)) in "PropositionNode" Implement (removeAlreadyWorkingOn(<Set>, <Channel>, <boolean>)) in "PropositionNode" May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant