-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incompatibility with Gnome Shell 3.36.0 #30
Comments
It's no big deal. I expect the extension to break with every GNOME Shell release, and I have weathered many,lol!!! Sometime I think you almost have to be a bit of a masochist though to be a extension dev. 3.36 releases tomorrow. I'll fire up something that has 3.36 on my secondary machine (aka the old computer the kids use to watch YouTube) this weekend and see what's going on. |
Thanks a lot - waiting for an update to this awesome extension. |
Well, turns out it wasn't any one huge or complicated issue, actually it was bunch a little things. I think I have everything sorted though. I will continue to tweak and test what I have though the weekend and at some point if everything checks out I'll push what I have. And then you guys check that out, then I fix anything that needs fix'n, rinse, repeat. |
any updates on the 3.36 version? |
Hold your horses,lol!!! It's coming. It will be done when it's done. |
Should be fixed with 5012185 |
testing - seems ok up to now. however, and this may be related to this old issue, chromium MPRIS is still not supported? For example, I can see netflix or spotify web controls in the notifications area of GNOME shell if I disable the extension, but not using the extension. |
I haven't checked this at all but this reminds me of p-e-w/argos#106 |
That's a problem with the theme. The cover icon uses the |
@terencode does 88a8fa2 fix that for you? |
I'm not sure if this has anything to do with what you're dealing with but if max-height/width is set in the style class then the size will be capped at that size regardless of what you set it to be with |
Yep, chromium/chrome exposes a broken interface. Also see #28 chromium/chrome isn't blacklisted or anything. As soon as they fix their shit it will start working. |
@JasonLG1979 yes, you are right it's coming from the theme (I'm using Plata) and unfortunately, your last commit doesn't fix it. I'll probably open an issue there. |
Do not upgrade to the new version of the gnome immediately after release. It’s better to wait a bit until everything grows together than to suffer from new bugs. ;) |
Then I'll revert it. I am by no means a CSS expert. |
I don't really have that option,lol!!! |
You, as an extension developer, I understand you. Gnome developers always break backward compatibility with each new version either on purpose or because of their curvature. But unfortunately the Gnome for me is the only DE in Linux with whom I organized my ideal workflow. |
There's never been a proper API. As far as they're concerned any breakage is in the implementation details, which by definition are not to be depended upon. That's their rational. Never mind the fact that I'd guess basically no one uses GNOME Shell without any extensions... |
Yep, that was one of those little things, but I thought I took care of that by manually setting the icon size to 16px? To be clear the above screenshot is of the current git master? Because I can't reproduce it with the current git master with either Adwaita (the default theme) or Yaru (Ubuntu's default Shell theme). |
Going forward though, I think I'm just going to test against those 2 themes to make life easier on myself. |
No, it's the latest version from https://extensions.gnome.org/, I am going to use your latest git master, and let you know. I'll let you know ASAP about the latest git master. |
Well this issue is about 3.36 Incompatibility. Running the current git master not on 3.36 will most likely not work very well if at all. |
You are right, and I am really sorry! I am really sorry... I don't know why but I was sure that the version from extensions.gnome.com was the latest one. Thanks for your time. |
It is the latest release. I just haven't finalized the 3.36 fixes yet. As soon as I do I will update it. If you look there is no 3.36 version up yet. |
I pushed a new version to the extensions site. I'm going to close this. If anyone has any other issues please start a new issue for that specific issue. |
Hello, I don't know if this is related, im on debian with 3.36.1, and while things seem to work, clicking does not work. Other extensions seem to be clickable, but Argos is not. Any ideas? Is this a new issue? |
Debian Testing then? I don't know what to tell you. I'm running Ubuntu 20.04. Have been since this issue was created. And everything works just fine. What version of the extension are you using?
This extension has nothing to do with Argos. Argos is here. |
Yes, so sorry! Mental mixup! This extension does work on sid :) I am very sorry. |
It's all good. |
The extension fails to load after an update to Gnome Shell 3.36.0
It's really weird and somewhat sad to see how extensions break with every release... The maintainer of https://github.com/p-e-w/argos essentially quit because of this.
The text was updated successfully, but these errors were encountered: