Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations #21

Open
JasonLG1979 opened this issue Nov 2, 2019 · 10 comments
Open

Translations #21

JasonLG1979 opened this issue Nov 2, 2019 · 10 comments
Labels
accessibility help wanted Extra attention is needed

Comments

@JasonLG1979
Copy link
Owner

This extension has a few user visible strings and strings that will be read a loud by screen readers that require translation.

It would be of great if someone would help me make that possible.

@JasonLG1979 JasonLG1979 added help wanted Extra attention is needed accessibility labels Nov 2, 2019
@JasonLG1979
Copy link
Owner Author

JasonLG1979 commented Nov 2, 2019

Update: So I've split out all translatable strings totranslations.js that is the only file that has translatable strings. Each translatable string has a very detailed description.

I've set it up so that once this extension has been translated to a language that translation should only ever need updating to add any additional future translations and any preexisting translations should not need touched, or ever break. The translations are independent of the rest of the code.

The actual build system still needs to be implemented though. That's where I could use someone's help that knows what they're doing, because I don't.

If a real build system is needed I would prefer meson over make.

@JasonLG1979 JasonLG1979 pinned this issue Nov 3, 2019
@JasonLG1979
Copy link
Owner Author

I've noticed a bit of a potential issue. Currently in some situations it may not be possible to get the translations in the right grammatical order because of how accessibility works in GNOME Shell.

For example when you mouse over a playlist item in the playlist menu the screen reader will say:

"player name PlayLists Item; playlist's name".

So for example it might say:

"Pithos Playlist Item; Imagine Dragon Radio".

(note that the ; is important. it causes the screen reader to pause a bit to make the speech sound a little more natural.)

That makes sense in English, but not so much maybe in other languages. The problem is that I can't change all of ordering of the phrase. The order of the the accessibility bit ("player name PlayLists Item;") can be changed, but it will always be before the playlist's name.

@saboya
Copy link

saboya commented Feb 16, 2020

I'll help you out with the PT-BR translation whenever I get the chance.

@JasonLG1979
Copy link
Owner Author

@saboya That would be awesome. Before you start I need to tweak some of the translatable strings a bit and actually get off my lazy butt and figure out how to finish the rest of the translations plumbing.

@mystiquewolf
Copy link

So where exactly do i place Bulgarian translations?

@fcastilloec
Copy link

I can help with Latinamerican Spanish translations whenever the code is ready.

@JasonLG1979
Copy link
Owner Author

JasonLG1979 commented May 15, 2020

I can help with Latinamerican Spanish translations whenever the code is ready.

I've been kinda dragging my feet on this. I need to do a lot of reading. I've never really dealt with translations before. Got to figure out how to do it.

@K3rcus
Copy link

K3rcus commented Jun 5, 2020

Very usefull extension, Great Work!

I don know at what point are you, but you can take a look at this video, at least it helped me to understand how manage translations. https://www.youtube.com/watch?v=WmWjwE-M4D0

About the screen reader issue, in Latin languages, spanish, italian, portuguese, ... can be written grammatically to fit this order, just let the translator know that, once you have the po files i can help with it.

@Vistaus
Copy link

Vistaus commented Jul 14, 2021

I'll do the Dutch translation once this is implemented 🙂

@ChrisLauinger77
Copy link
Contributor

ChrisLauinger77 commented Oct 31, 2022

Created the pull request #68 - german translation is already included also the pot file which can be used to create more translations (I used poedit https://packages.debian.org/bookworm/poedit )
usually the pot/po files are the ones which checked in
the command "gnome-extensions pack --podir=../po [email protected]" (in our case) will create a zip with the correct locale structure out of the *.po files

More info https://gjs.guide/extensions/development/translations.html#marking-strings-for-translation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

7 participants