Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioning and release tags #35

Open
gauthamchandra opened this issue Feb 9, 2016 · 5 comments
Open

Add versioning and release tags #35

gauthamchandra opened this issue Feb 9, 2016 · 5 comments

Comments

@gauthamchandra
Copy link

The code currently has no versioning and it would be nice to have versioning on this.

Once versioning and release tags are setup, I can open a PR for a homebrew formula for this utility so that new users can just do:

brew install tespeed

According to homebrew docs:

Formulae in the core repository must have a stable version tagged by the upstream project. Tarballs are preferred to git checkouts, and tarballs should include the version in the filename whenever possible.

Full details on Homebrew Versioning

You could also just have a bleeding edge formula that might break when users run brew update but its not optimal.

@thanegill
Copy link

👍

@Janhouse
Copy link
Owner

Good idea, I added v1.1 tag.

@gauthamchandra
Copy link
Author

I decided to go via pip instead of via homebrew as its a python module.

I have gotten almost everything setup but I am just a bit stuck on this annoying issue of it not resolving the custom SocksiPy lib you have in your repo.

Seems pip doesn't like the fact that it's a submodule.

I am going to see if I can hack around it with requirements files.

@Janhouse
Copy link
Owner

Yes, seems like Github didn't want to include it in the release automatically. 😭

@gauthamchandra
Copy link
Author

Just need a code review and I am good to go. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants