Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update launching flow to include status dialogue #68

Open
plante-msft opened this issue Jul 1, 2024 · 7 comments
Open

Update launching flow to include status dialogue #68

plante-msft opened this issue Jul 1, 2024 · 7 comments
Assignees
Labels
launcher P0 Highest priority item, ship blocking solved

Comments

@plante-msft
Copy link
Collaborator

plante-msft commented Jul 1, 2024

Update launch flow to add a flyout dialogue while project is launching:

  • Flyout dialogue updates each app's status with a green check once app is launched and in position.
  • Dismiss button to dismiss dialogue from view.
  • Cancel button to cancel project launch. This is a hard cancel on the launch execution flow, but does not "clean up" apps that have already launched.
  • Flyout persists for 1 second after all apps have launched before automatically dismissing itself.

Image

  • Spinner is applied while app is launching
  • Green check is applied once app has successfully launched
  • Red X is applied if launch fails

cc @crutkas @hamza-usmani

@plante-msft plante-msft added P0 Highest priority item, ship blocking launcher labels Jul 1, 2024
@hamza-usmani
Copy link
Collaborator

Notes:

  • "Dismiss" and "Cancel" should be flipped following common UX/UI priniciples Best practice UX: Proceed/continue actions are on the right, negate or cancel actions on the left

@plante-msft
Copy link
Collaborator Author

Notes:

  • "Dismiss" and "Cancel" should be flipped following common UX/UI priniciples Best practice UX: Proceed/continue actions are on the right, negate or cancel actions on the left

Somehow these got switched and the other launch flyout was removed from the original screenshot - thanks for calling this out. Image has been updated.

@hamza-usmani
Copy link
Collaborator

Another note: If an app is loading, it should not have a check or X, simply blank. I am assuming this is what is being represented above (ie. Terminal has failed to launch and the other apps have succeeded, not that terminal has not yet launched)

@plante-msft
Copy link
Collaborator Author

Good callout - updated to include the third variant.

@plante-msft
Copy link
Collaborator Author

@donlaci @SeraphimaZykova should we gate the same project's launch behind the dialogues presence on-screen? Thinking of how to account for an accidental double-launch (ex. double-clicking taskbar icon)

@SeraphimaZykova
Copy link
Member

@donlaci @SeraphimaZykova should we gate the same project's launch behind the dialogues presence on-screen? Thinking of how to account for an accidental double-launch (ex. double-clicking taskbar icon)

I think that would make sense. We can add a mutex to prevent multiple instances of Launcher from running, ensuring that only one project launches at a time.

@donlaci donlaci added the solved label Aug 5, 2024
@donlaci donlaci self-assigned this Aug 5, 2024
@plante-msft
Copy link
Collaborator Author

@donlaci apologies as I should have specified this in the original issue - the loading circle displayed while the app is launching should be animated

Image

Alt Text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
launcher P0 Highest priority item, ship blocking solved
Projects
None yet
Development

No branches or pull requests

4 participants