Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflicts in ending words? #2

Open
aerickt opened this issue Nov 14, 2020 · 1 comment
Open

Conflicts in ending words? #2

aerickt opened this issue Nov 14, 2020 · 1 comment

Comments

@aerickt
Copy link

aerickt commented Nov 14, 2020

https://github.com/JeremyGG/plover_phrasing/blob/25ee658dde855bb41adf7c959faa10c56cb76e6e/ps2.py#L111

https://github.com/JeremyGG/plover_phrasing/blob/25ee658dde855bb41adf7c959faa10c56cb76e6e/ps2.py#L104

I can't really tell why there are two ending phrases defined with the same stroke. Is this a mistake?
@Jade-GG
Copy link
Owner

Jade-GG commented May 9, 2021

Whoops, only saw this now, sorry. I was going to fix it by changing "knew that" into "PBTD", but it turns out that creates a conflict with "knew that" and "need to".

I guess I'll just delete "knew that" from the list for now, I can't really think of a good consistent stroke for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jade-GG @aerickt