You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
I think type hints are extremely valuable. I've noticed that there could be better type hints in your code. Would you be interested in this?
Describe the solution you'd like
I can give you an example. Instead of making a dictionary with the type and then popping the dictionary, you can modify the code to allow for type hints. You wouldn't have to pop anything either.
Before:
class FEModel3D():
def init(self):
self.Nodes = {str:Node3D} # A dictionary of the model's nodes
self.Nodes.pop(str)
After:
from typing import Dict
class FEModel3D():
def __init__(self):
self.Nodes: Dict[str, Node3D] = {} # A dictionary of the model's nodes
Describe alternatives you've considered
See above
Additional context
N/A
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
I think type hints are extremely valuable. I've noticed that there could be better type hints in your code. Would you be interested in this?
Describe the solution you'd like
I can give you an example. Instead of making a dictionary with the type and then popping the dictionary, you can modify the code to allow for type hints. You wouldn't have to pop anything either.
Before:
class FEModel3D():
def init(self):
self.Nodes = {str:Node3D} # A dictionary of the model's nodes
self.Nodes.pop(str)
After:
from typing import Dict
Describe alternatives you've considered
See above
Additional context
N/A
The text was updated successfully, but these errors were encountered: