Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor internal functions to be defined outside of plot functions #80

Open
the-mayer opened this issue Oct 8, 2024 · 3 comments
Open
Assignees
Labels
good first issue Good for newcomers outreachy for outreachy interns package R package dev

Comments

@the-mayer
Copy link
Collaborator

          Tagging functions for future review. 

The following internal functions should be defined outside of the plotting functions that currently use them. This way, the plot functions can reference these external functions, avoiding the need to define functions within functions.

  • .LevelReduction()
  • .GetKingdom()

Originally posted by @the-mayer in #63 (comment)

@the-mayer the-mayer added outreachy for outreachy interns good first issue Good for newcomers labels Oct 8, 2024
@teddyCodex teddyCodex self-assigned this Oct 8, 2024
@teddyCodex
Copy link
Collaborator

taking a crack at this @the-mayer

@Joiejoie1
Copy link
Collaborator

@teddyCodex are you working on this or can I give it a shot as well?

@teddyCodex
Copy link
Collaborator

Hi @Joiejoie1 Already raised a PR
Waiting on @the-mayer to review.

@jananiravi jananiravi added the package R package dev label Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers outreachy for outreachy interns package R package dev
Projects
None yet
Development

No branches or pull requests

4 participants