Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Add error handling for functions #30

Open
3 tasks
Seyi007 opened this issue Oct 4, 2024 · 10 comments
Open
3 tasks

[FEAT] Add error handling for functions #30

Seyi007 opened this issue Oct 4, 2024 · 10 comments
Assignees
Labels
coding Coding experience (of any sort) would be helpful enhancement New feature or request outreachy for outreachy interns package R package dev

Comments

@Seyi007
Copy link
Collaborator

Seyi007 commented Oct 4, 2024

Requirements

  • Ensure that all inputs are validated before processing. If inputs are invalid, return a user-friendly error message.
  • Implement try-catch blocks where appropriate to handle exceptions gracefully without crashing the application.
  • Update the documentation to include information about the new error-handling behavior

Acceptance Criteria

  • All inputs are validated, and error messages are clear and informative.
  • Exceptions are caught and logged appropriately without crashing the application.
  • Documentation is updated to reflect the changes made.
@Seyi007 Seyi007 added enhancement New feature or request outreachy for outreachy interns labels Oct 4, 2024
@Seyi007
Copy link
Collaborator Author

Seyi007 commented Oct 4, 2024

Hi @jananiravi, issues #29 and this has been created as requested.

@jananiravi jananiravi added package R package dev coding Coding experience (of any sort) would be helpful labels Oct 4, 2024
@Klangina
Copy link

Klangina commented Oct 4, 2024

@jananiravi can I kindly be assigned this task?

@jananiravi
Copy link
Member

Sure! Can you post a note about which files/functions you're starting with so that others can contribute in parallel, too? Thanks!

@Seyi007
Copy link
Collaborator Author

Seyi007 commented Oct 5, 2024

Hi @Klangina, I'm creating the error handling mechanism on the R/acc2lin.R file. However, if you have started working on this, please leave a message so I can work on a different file.

@Seyi007
Copy link
Collaborator Author

Seyi007 commented Oct 6, 2024

Error handling is done for the R/acc2lin.R file. What files are you working on @Klangina?

@Seyi007
Copy link
Collaborator Author

Seyi007 commented Oct 8, 2024

Error handling and function names update is done for R/assign_job_queue.R file @jananiravi

@Seyi007
Copy link
Collaborator Author

Seyi007 commented Oct 8, 2024

Hi @awasyn, kindly drop updates on the files you're working on to avoid duplicating the same thing.

@awasyn
Copy link
Collaborator

awasyn commented Oct 8, 2024

Hey @Seyi007 . I added input checks for tree, summarize, reverse_operons and pre-msa-tree.
I am currently working on unit tests since it has less action and is isolated. I have dependent PRs for fa2domain, cleanup.

@Seyi007
Copy link
Collaborator Author

Seyi007 commented Oct 9, 2024

Okay @awasyn , well done! I'm currently working on the error handling for R/blastWrappers.R @Klangina

@Seyi007
Copy link
Collaborator Author

Seyi007 commented Oct 9, 2024

Error handling for functions in R/blastWrappers.R is done, with pr #76 @jananiravi @the-mayer

@jananiravi jananiravi changed the title 🆕 [FEAT] Add error handling for functions [FEAT] Add error handling for functions Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coding Coding experience (of any sort) would be helpful enhancement New feature or request outreachy for outreachy interns package R package dev
Projects
None yet
Development

No branches or pull requests

5 participants