Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all public methods of client and socketclient virtual #42

Open
EpsilonD3lta opened this issue Aug 14, 2021 · 2 comments
Open

Make all public methods of client and socketclient virtual #42

EpsilonD3lta opened this issue Aug 14, 2021 · 2 comments

Comments

@EpsilonD3lta
Copy link

Feature request
Make all public/protected methods of client and socketclient virtual. I would like to override some methods to customize the clients. I can make a new client, but for small changes the inheritance would be preferable.

@JKorf
Copy link
Owner

JKorf commented Aug 18, 2021

I'd prefer not to do this, since I would like to have the client updated with anything that users would need. Making everything overridable makes it so that a user might just fix/add something for themselfs instead of reporting/requesting it ;)

You could just fork the source and directly use it in your code if you wish.

Is there any specific thing you would like to see added/changed? Maybe I could implement it.

@EpsilonD3lta
Copy link
Author

EpsilonD3lta commented Aug 18, 2021

I want to make two things:

  1. Per method limiter.
    Sometimes I want to limit only specific calls that have lower priority

  2. I would like to create mockup client for testing or simulation with local data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants